This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Dependencies update (TS 1.8.7) #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valorkin
commented
Mar 11, 2016
valorkin
commented
- all dependencies updated
- deps made immutable (save-exact)
- typescript added as dev dependency
- TS version set to 1.8.7
|
Thanks. We follow the standard ESLint guidelines for pull requests: So, we need separate PRs for each commit and for the commit summaries to be in a specific format. |
- all dependencies was updated - dependencies was made immutable - TS was added as dev dependecy
|
@nzakas ready for merge |
| @@ -26,18 +26,19 @@ | |||
| } | |||
| ], | |||
| "devDependencies": { | |||
| "chai": "^1.10.0", | |||
There was a problem hiding this comment.
I'd prefer not to hardcode dependency versions.
There was a problem hiding this comment.
you prefer to have broken version because of someone changes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.